fix: address Final Verification Wave findings

- Sync() now flushes BlockWriter before fd.Sync() for durability
- Pre-validate encoding before sequence allocation (design doc compliance)
- Remove dead _ = rec assignment in recover.go
- Remove unused maxPayload field from SegmentWriter
- Handle Put error in MemTable.Publish with panic on invariant violation
This commit is contained in:
dailz
2026-06-12 14:29:53 +08:00
parent 5905dbc06f
commit b833a21848
5 changed files with 100 additions and 10 deletions
+84 -2
View File
@@ -8,7 +8,7 @@
"plan_name": "phase1-wal",
"status": "active",
"started_at": "2026-06-12T05:09:32.588Z",
"updated_at": "2026-06-12T06:20:06.478Z",
"updated_at": "2026-06-12T06:29:05.569Z",
"session_ids": [
"opencode:ses_145c3bae9ffeTB2zbsTym0Cev8"
],
@@ -146,6 +146,47 @@
"status": "completed",
"ended_at": "2026-06-12T06:20:06.478Z",
"elapsed_ms": 85727
},
"final-wave:f1": {
"task_key": "final-wave:f1",
"task_label": "F1",
"task_title": "**Plan Compliance Audit** — `oracle`",
"session_id": "opencode:ses_1457cb69affe9rYiUhKWDB2kDd",
"agent": "Sisyphus-Junior",
"category": "unspecified-high",
"started_at": "2026-06-12T06:23:49.269Z",
"status": "running",
"updated_at": "2026-06-12T06:29:05.572Z"
},
"final-wave:f3": {
"task_key": "final-wave:f3",
"task_label": "F3",
"task_title": "Real Manual QA — execute all QA scenarios from the plan and verify cross-module integration.",
"session_id": "opencode:ses_1458206c0ffeyx0AQoGlHap1Wb",
"agent": "oracle",
"updated_at": "2026-06-12T06:23:50.560Z",
"started_at": "2026-06-12T06:23:50.560Z",
"status": "running"
},
"final-wave:f2": {
"task_key": "final-wave:f2",
"task_label": "F2",
"task_title": "Code Quality Review — run static analysis and review all .go files for quality issues.",
"session_id": "opencode:ses_145823a08ffeN5NdqAbplhAFfu",
"agent": "oracle",
"updated_at": "2026-06-12T06:23:51.328Z",
"started_at": "2026-06-12T06:23:51.328Z",
"status": "running"
},
"final-wave:f4": {
"task_key": "final-wave:f4",
"task_label": "F4",
"task_title": "Scope Fidelity Check — verify each task's implementation matches its spec with no scope creep.",
"session_id": "opencode:ses_14581c42cffeKPlQGJV5yvUNk5",
"agent": "oracle",
"updated_at": "2026-06-12T06:24:29.653Z",
"started_at": "2026-06-12T06:24:29.653Z",
"status": "running"
}
}
}
@@ -153,7 +194,7 @@
"active_plan": "/home/dailz/workspace/src/go-kv/.omo/plans/phase1-wal.md",
"started_at": "2026-06-12T05:09:32.588Z",
"status": "active",
"updated_at": "2026-06-12T06:20:06.478Z",
"updated_at": "2026-06-12T06:29:05.569Z",
"session_ids": [
"opencode:ses_145c3bae9ffeTB2zbsTym0Cev8"
],
@@ -291,6 +332,47 @@
"status": "completed",
"ended_at": "2026-06-12T06:20:06.478Z",
"elapsed_ms": 85727
},
"final-wave:f1": {
"task_key": "final-wave:f1",
"task_label": "F1",
"task_title": "**Plan Compliance Audit** — `oracle`",
"session_id": "opencode:ses_1457cb69affe9rYiUhKWDB2kDd",
"agent": "Sisyphus-Junior",
"category": "unspecified-high",
"started_at": "2026-06-12T06:23:49.269Z",
"status": "running",
"updated_at": "2026-06-12T06:29:05.572Z"
},
"final-wave:f3": {
"task_key": "final-wave:f3",
"task_label": "F3",
"task_title": "Real Manual QA — execute all QA scenarios from the plan and verify cross-module integration.",
"session_id": "opencode:ses_1458206c0ffeyx0AQoGlHap1Wb",
"agent": "oracle",
"updated_at": "2026-06-12T06:23:50.560Z",
"started_at": "2026-06-12T06:23:50.560Z",
"status": "running"
},
"final-wave:f2": {
"task_key": "final-wave:f2",
"task_label": "F2",
"task_title": "Code Quality Review — run static analysis and review all .go files for quality issues.",
"session_id": "opencode:ses_145823a08ffeN5NdqAbplhAFfu",
"agent": "oracle",
"updated_at": "2026-06-12T06:23:51.328Z",
"started_at": "2026-06-12T06:23:51.328Z",
"status": "running"
},
"final-wave:f4": {
"task_key": "final-wave:f4",
"task_label": "F4",
"task_title": "Scope Fidelity Check — verify each task's implementation matches its spec with no scope creep.",
"session_id": "opencode:ses_14581c42cffeKPlQGJV5yvUNk5",
"agent": "oracle",
"updated_at": "2026-06-12T06:24:29.653Z",
"started_at": "2026-06-12T06:24:29.653Z",
"status": "running"
}
},
"agent": "atlas"