DecodePhysicalRecord only checked length upper bound, not lower bound
(length > 0 per design §3.2 line 389). It also didn't validate the
fragment type field (RecInvalid=0 and types > RecLast are corruption
indicators per design §3.2 line 366-372).
Corrupt data with length=0 could pass CRC (payload is empty, CRC only
covers length+type bytes) and inject empty records into the fragment
collector. Invalid type values would only be caught at the collector
level, wrapped as TailCorruptionError, rather than rejected at the
parser level.
Changes:
- wal/record.go: DecodePhysicalRecord now rejects length=0 and
type ∉ {RecFull..RecLast} before payload copy and CRC check.
Checks are ordered to reject invalid records ASAP.
- wal/record_test.go: 5 tests:
- TestDecodePhysicalRecord_RejectZeroLength (H1)
- TestDecodePhysicalRecord_RejectInvalidType (H2, type=0)
- TestDecodePhysicalRecord_RejectUnknownType (H2, type>RecLast)
- TestDecodePhysicalRecord_ValidRecordsUnaffected (regression for
all 4 valid types)
- TestParseBlockWrapsInvalidRecordAsTailCorruption (integration:
ParseBlock wraps H1/H2 errors as TailCorruptionError)
Verified: all existing tests pass. Full suite green including
go test -race ./... .
Audit context: docs/audit-3.2.md H1+H2.
- go.mod with github.com/dailz/go-kv, Go 1.26.3, testify
- config/config.go with WalConfig, Validate() with checked arithmetic
- errors.go with sentinel errors (ErrCommitUnknown, ErrWriteStopped, etc.)
- wal/constants.go with all WAL format constants and enums
- wal/header.go with WAL File Header encode/decode (CRC32 IEEE)
- wal/record.go with Physical Record codec, block boundary, SplitIntoRecords
- wal/entry.go with WAL Entry codec (varint keys/values, OpType, ValueKind)
- wal/sequence.go with SequenceManager (atomic, CAS, overflow-safe)
- manifest/manifest.go with MANIFEST stub (Load/Save atomic)
- manifest/current.go with CURRENT file (WriteCurrent/ReadCurrent)
- Comprehensive tests for all modules
- .golangci.yml configuration
dailz