Top-level gate: if .is_ok() → match, Err branch prints WARNING and skips all cold benchmarks
bench_cold_open(): let _ = → match, Err branch prints per-backend WARNING and returns Vec::new() to avoid producing misleading cold_open data
Fixed in 5024796.
Changes in crates/bench/src/suites/startup.rs:
1. Top-level gate: if .is_ok() → match, Err branch prints WARNING and skips all cold benchmarks
2. bench_cold_open(): let _ = → match, Err branch prints per-backend WARNING and returns Vec::new() to avoid producing misleading cold_open data
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
问题
startup::run在非 quick 模式下只有clear_file_cache(&test_file).is_ok()时才运行 cold open benchmarks;失败时没有任何提示。影响
用户会缺失冷启动数据,但报告中没有解释原因。
位置
crates/bench/src/suites/startup.rs:42建议
改成
match,失败时输出WARNING: Cannot clear file cache, skipping cold startup benchmarks: {e}。Fixed in
5024796.Changes in crates/bench/src/suites/startup.rs: