🟡 [M22] cold startup benchmark 因 clear_file_cache 失败被静默跳过 #41

New Issue

dailz · 2026-06-05T11:54:15+08:00

dailz commented

2026-06-05 11:54:15 +08:00

问题

startup::run 在非 quick 模式下只有 clear_file_cache(&test_file).is_ok() 时才运行 cold open benchmarks；失败时没有任何提示。

影响

用户会缺失冷启动数据，但报告中没有解释原因。

位置

crates/bench/src/suites/startup.rs:42

建议

改成 match，失败时输出 WARNING: Cannot clear file cache, skipping cold startup benchmarks: {e}。

## 问题 `startup::run` 在非 quick 模式下只有 `clear_file_cache(&test_file).is_ok()` 时才运行 cold open benchmarks；失败时没有任何提示。 ## 影响用户会缺失冷启动数据，但报告中没有解释原因。 ## 位置 - `crates/bench/src/suites/startup.rs:42` ## 建议改成 `match`，失败时输出 `WARNING: Cannot clear file cache, skipping cold startup benchmarks: {e}`。

dailz referenced this issue from a commit

2026-06-05 17:29:05 +08:00

fix(bench): warn when clear_file_cache fails instead of silently skipping cold benchmarks (closes #41)

dailz closed this issue

2026-06-05 17:29:05 +08:00

dailz commented

2026-06-05 17:29:19 +08:00

Fixed in 5024796.

Changes in crates/bench/src/suites/startup.rs:

Top-level gate: if .is_ok() → match, Err branch prints WARNING and skips all cold benchmarks
bench_cold_open(): let _ = → match, Err branch prints per-backend WARNING and returns Vec::new() to avoid producing misleading cold_open data

Fixed in 5024796. Changes in crates/bench/src/suites/startup.rs: 1. Top-level gate: if .is_ok() → match, Err branch prints WARNING and skips all cold benchmarks 2. bench_cold_open(): let _ = → match, Err branch prints per-backend WARNING and returns Vec::new() to avoid producing misleading cold_open data

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dailz/logViewer#41