dailz

dailz pushed to master at dailz/wl-webrtc

2026-06-06 15:54:18 +08:00

7c1c9b2e19 fix(avhw): add SAFETY comments to all undocumented unsafe blocks

dailz commented on issue dailz/wl-webrtc#6

2026-06-06 15:14:40 +08:00

Bug: tx.send() 失败被静默忽略，编码器继续无效工作 (avhw.rs)

修复方案

第一层：channel 断开检测（SendError）

drain_encoder() 中将 let _ = tx.send(data.to_vec()) 替换为：

if let Err(e) = tx.send(data.to_vec()) {
    tracing::warn!("WebRTC…

dailz pushed to master at dailz/wl-webrtc

2026-06-06 15:12:56 +08:00

226768c3e3 fix(avhw): handle tx.send() failure and pause encoding on WebRTC disconnect (closes #6)

fd170b66d9 fix(unsafe): add SAFETY comment and runtime guards for from_raw_parts in drain_encoder

Compare 2 commits »

dailz closed issue dailz/wl-webrtc#6

2026-06-06 15:12:56 +08:00

Bug: tx.send() 失败被静默忽略，编码器继续无效工作 (avhw.rs)

dailz closed issue dailz/wl-webrtc#5

2026-06-06 11:58:29 +08:00

unsafe: drain_encoder 中使用 from_raw_parts 应添加 SAFETY 注释 (avhw.rs)

dailz commented on issue dailz/wl-webrtc#5

2026-06-06 11:58:09 +08:00

unsafe: drain_encoder 中使用 from_raw_parts 应添加 SAFETY 注释 (avhw.rs)

修复方案

提交: fd170b6

问题: drain_encoder 中 std::slice::from_raw_parts 缺少 SAFETY 注释，且存在两个潜在 soundness 风险：

pkt.size 为负数时 as usize 会包装成巨大值 2.…

dailz closed issue dailz/wl-webrtc#4

2026-06-06 11:50:34 +08:00

低风险: 多实例运行时令牌文件竞态条件 (cap_portal.rs)

dailz commented on issue dailz/wl-webrtc#4

2026-06-06 11:50:18 +08:00

低风险: 多实例运行时令牌文件竞态条件 (cap_portal.rs)

经审核，单实例场景下 load_restore_token 和 save_restore_token 在 setup_portal 中是串行调用（L192 读 → L227 写），不存在竞态条件。此 issue 仅在多实例同时运行时成立，当前不考虑该场景，故关闭。

dailz closed issue dailz/wl-webrtc#3

2026-06-06 11:45:17 +08:00

安全: 多用户环境下令牌回退路径冲突 (cap_portal.rs)

dailz commented on issue dailz/wl-webrtc#2

2026-06-06 11:05:22 +08:00

安全: 令牌文件未设置限制性权限 (cap_portal.rs)

修复完成

已在 commit 9a5b09c 中修复，基于 Oracle 安全审计建议实施。

改动摘要

token_path() — 返回 Option<PathBuf>，移…

dailz closed issue dailz/wl-webrtc#2

2026-06-06 11:05:07 +08:00

安全: 令牌文件未设置限制性权限 (cap_portal.rs)

dailz pushed to master at dailz/wl-webrtc

2026-06-06 11:05:07 +08:00

9a5b09cd7f fix(security): harden token file permissions (closes #2)

46367ef6b5 fix(state): add WebRTC support to wlr-screencopy backend

Compare 2 commits »

dailz created pull request dailz/logViewer#46

2026-06-05 17:34:56 +08:00

fix: [M23] 小文件 single_frame_tail 与 head 重叠导致 render 数据误导

dailz created branch fix/m23-single-frame-tail-overlap in dailz/logViewer

2026-06-05 17:32:24 +08:00

dailz pushed to fix/m23-single-frame-tail-overlap at dailz/logViewer

2026-06-05 17:32:24 +08:00

dailz commented on issue dailz/logViewer#41

2026-06-05 17:29:19 +08:00

🟡 [M22] cold startup benchmark 因 clear_file_cache 失败被静默跳过

Fixed in 5024796.

Changes in crates/bench/src/suites/startup.rs:

Top-level gate: if .is_ok() → match, Err branch prints WARNING and skips all cold benchmarks
bench_cold_open(): let _ = →…

dailz pushed to master at dailz/logViewer

2026-06-05 17:29:05 +08:00

502479677b fix(bench): warn when clear_file_cache fails instead of silently skipping cold benchmarks (closes #41)

5656b26d7b refactor(bench): unify line counting in get_file_info to use count_existing_lines

a8b64e78bd fix(bench): stabilize report column/row ordering across input permutations (#39)

Compare 3 commits »

dailz closed issue dailz/logViewer#41

2026-06-05 17:29:05 +08:00

🟡 [M22] cold startup benchmark 因 clear_file_cache 失败被静默跳过

dailz closed issue dailz/logViewer#40

2026-06-05 17:05:36 +08:00

🟡 [M21] get_file_info 与 count_existing_lines 对无尾换行文件计数不一致

dailz commented on issue dailz/logViewer#40

2026-06-05 17:05:29 +08:00

🟡 [M21] get_file_info 与 count_existing_lines 对无尾换行文件计数不一致

经审核，原 issue 描述的不一致实际不存在：read_until(b'\n') 和 lines().count() 对无尾换行文件的行为一致，均会计入最后一行。

但为减少重复代码和维护风险，已将 get_file_info 中的手动 read_until…