3 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
dailz	fed8c2dcfd	docs(avhw): fix misleading Send soundness reasoning ... Oracle audit of all 5 `unsafe impl Send` in src/avhw/ found soundness intact but reasoning wrong in 3 of 5: - AvHwDevCtx: claimed '&mut self ensures exclusive access' — false, ref_clone() hands raw pointers to other threads / FFmpeg-internal codec workers. Real basis is AVBufferRef atomic_uint refcount + libva VADisplay thread safety. - AvHwFrameCtx: claimed 'send/receive pattern is thread-safe' — misdirection. Real basis is AVBufferPool atomic get/put. - EncState: claimed 'raw pointers not shared across threads' — false when FFmpeg frame/slice threading is enabled. Real basis is the hw device/frames contexts being designed for such sharing. SwEncState and SwEncEncode comments were acceptable; improved for clarity (note that contained FFmpeg handles are non-thread-safe but Send-sound under exclusive access, and that crossbeam/Arc fields are already Send by design). Added module-level convention doc to src/avhw/mod.rs centralizing the C-API-level justification rule and explicitly calling out the '&mut self as Send basis' anti-pattern so future contributors don't repeat the category error. Fixed AGENTS.md: - Stale claim that Cargo.toml 'only warns' on undocumented_unsafe_blocks (it's been 'deny' for a while) - Stale path src/avhw.rs → src/avhw/ (split in d53e881) - Stale 'avoid moving wrappers across threads' guidance — Send is sound, the audit just confirmed why No code behavior change. Verified: cargo build --release, cargo clippy --release --all-targets (0 warnings), cargo test --release (79 unit + 3 integration, 1 ignored).	2026-07-09 15:20:16 +08:00
dailz	9a7b745a0e	refactor(state): make output probe readiness transform-only ... Drops PartialOutputInfo.physical_size and .logical_position. After the warning cleanup in 6332472 these fields were probe-time-only gates with no downstream consumer (encoder reads geometry from the dmabuf frame itself, not from wl_output description). Readiness simplification (try_finalize_output): - xdg-output path (Sway/Hyprland): done_count >= 2 + name + transform - wlr-output-management path (niri): done_count >= 1 + wlr_manager_done + transform Safe because Wayland protocol guarantees Geometry/Mode/Position events fire before Done, so done_count >= N implies the prior events arrived. done_count is the real signal; the per-field .is_none() checks were redundant belt-and-suspenders. Cascading cleanup of writers that only fed the deleted fields: - WlOutput::Geometry handler — drop physical_size write, keep transform - XdgOutputEvent::LogicalPosition arm — deleted - WlrHeadEvent::Position arm — deleted (was the only reader of wlr_head_proxy_to_name; both maps now write-only markers) - WlrHeadInfo.position field — deleted; struct becomes empty marker Behavior change risk: probe may finalize slightly earlier in cases where a compositor fires Done before physical_size/logical_position events (protocol violation, but possible). Verified with cargo test --release (79 unit + 3 integration, 1 ignored). Hardware/Wayland-session test deferred to user. Net: -48 lines.	2026-07-09 14:48:10 +08:00
dailz	633247201c	refactor: clear remaining clippy dead-code and cast warnings ... Brings `cargo clippy --release --all-targets` and `cargo build --release` to zero warnings. Three categories: Truly dead code (deleted): - OutputInfo.physical_size / .logical_position — copied from PartialOutputInfo at construction but never read on OutputInfo; PartialOutputInfo still uses them as probe-completion gates - EncConstructionStage::Streaming.output_info — stored at ->Streaming transition, all 9 match arms discard via `..` or `output_info: _` - State.starting_timestamp — vestigial Phase 1 stub; PTS normalization lives in EncState / SwEncState instead (commit 079611a) - cap_portal::fourcc() const fn — superseded by drm_fourcc::DrmFourcc - PwThreadCtx.fps — destructured as `fps: _`, never consumed Lifetime/ownership invariants (kept with #[allow(dead_code)] + reason): - CapPortal.rt — ashpd caches a zbus::Connection in a process-global OnceCell; runtime must outlive CapPortal or the connection hangs - EncState.hw_device_ctx — root AVHWDeviceContext; consumers hold their own ref_clone() but the root ref must stay alive for ownership False-positive warning (annotated): - state_portal use AsRawFd — required at FFI boundary but rustc mis-attributes the call to OwnedFd's inherent method; E0599 if removed Cosmetic: - drop 5 redundant `as *const i32` casts on linesize.as_ptr() in avhw/encode.rs and bin/vaapi_import_bench.rs	2026-07-09 14:36:10 +08:00